Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83414?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: libpayload/x86: Add x86-64 support to rdtsc()
......................................................................
Patch Set 2:
(2 comments)
File payloads/libpayload/include/x86/arch/rdtsc.h:
https://review.coreboot.org/c/coreboot/+/83414/comment/f4fc508f_8a1bacf2?usp... :
PS2, Line 37: unsigned int
better: u32
https://review.coreboot.org/c/coreboot/+/83414/comment/9eb4c033_63187863?usp... :
PS2, Line 40: }
Let's just use this version for both cases rather than having an `#if`. It means the same anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83414?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0afac3db2e82a245a37c2e5cf2302bf1dad62c01
Gerrit-Change-Number: 83414
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Noga Smith
nogasmith@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
Gerrit-Comment-Date: Wed, 10 Jul 2024 18:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No