Attention is currently required from: Felix Singer, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52789 )
Change subject: soc/intel/skylake: Drop EXCLUDE_NATIVE_SD_INTERFACE
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/skylake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/52789/comment/c1eba356_34fe4a31
PS5, Line 120: 0x4c4
That's an interesting thought. My understanding was that with the _ADR […]
If we wanted to be really safe, we could provide a _STA method that returns some value passed via acpigen, e.g. the devicetree device's state, or `ScsSdCardEnabled`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id07f59b5252cf3862724d6ff3d7c54d51ccfd9a6
Gerrit-Change-Number: 52789
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 17 Dec 2021 09:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-MessageType: comment