Attention is currently required from: Furquan Shaikh, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56308 )
Change subject: mb/google/brya: add BASEBOARD_DIR to support different baseboard ......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/56308/comment/e5eb6155_20fac3c8 PS1, Line 1: BOARD_GOOGLE_BASEBOARD_BRYA
This will have to be updated to allow for different Kconfigs for different baseboards. […]
Yes, i'm going to push another patch for the Brask. I'll refer to the CL you provide. Thanks!
https://review.coreboot.org/c/coreboot/+/56308/comment/370a03c3_4f7554ab PS1, Line 37: config BASEBOARD_BRYA_LAPTOP : def_bool n : select SYSTEM_TYPE_LAPTOP
There is some clean up required for this as well. […]
ok, i'll submit a patch for this.
https://review.coreboot.org/c/coreboot/+/56308/comment/a0bf4344_b09b508e PS1, Line 46: CHROMEOS_DRAM_PART_NUMBER_IN_CBI
I think this is specific to brya baseboard. […]
Yes, i'll submit another CL to change the memory setting.
https://review.coreboot.org/c/coreboot/+/56308/comment/59c2ac1f_7a21972c PS1, Line 77: BOARD_GOOGLE_BRYA0
This will have to be changed to BOARD_GOOGLE_BASEBOARD_BRYA. Also the string should be Google_Brya.
yes, i'll change this too.