Patrik Tesarik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40527 )
Change subject: payloads/external/LinuxBoot: Change Kconf defaults ......................................................................
payloads/external/LinuxBoot: Change Kconf defaults
In addition to change I4ac3409040ea77a1836f90f43fba07d2cd05a952 this commit proposes a change of default behavior inside of the LinuxBoot tool chain.
Currently the defaults build a LinuxBoot payload which boots into the U-root shell and waits for input. In fact it does not deliver any bootloader with it, but the build image is on the other hand rather small.
This commit will change the defaults in a way that the LinuxBoot bootloader will actually be able to boot a local or remote system image. In consequence the build payload size is rather big, but accepted for a working out-of-the-box startup behavior.
See discussion on that topic in the above mentioned change.
Signed-off-by: Patrik Tesarik mail@patrik-tesarik.de Change-Id: Ieaba7e523aef10c467a8bea29ae323e22324b225 --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/40527/1
diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 8f4137d..84e3db8 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -267,19 +267,19 @@
config LINUXBOOT_UROOT_COMMANDS string "U-root commands" - default "coreboot-app" + default "all" help List of additional modules to include, - separated by space. (default "coreboot-app") + separated by space. (default "all")
if LINUXBOOT_UROOT_MASTER
choice prompt "Choose a specific bootloader" - default SPECIFIC_BOOTLOADER_NONE + default SPECIFIC_BOOTLOADER_SYSTEMBOOT help Specify a bootloader which starts after u-root init. It will be a symlink - to /bin/uinit. Default: None + to /bin/uinit. Default: systemboot
config SPECIFIC_BOOTLOADER_NONE bool "none"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40527
to look at the new patch set (#2).
Change subject: payloads/external/LinuxBoot: Change Kconf defaults ......................................................................
payloads/external/LinuxBoot: Change Kconf defaults
In addition to change I4ac3409040ea77a1836f90f43fba07d2cd05a952 this commit proposes a change of default behavior inside of the LinuxBoot tool chain.
Currently the defaults build a LinuxBoot payload which boots into the U-root shell and waits for input. In fact it does not deliver any bootloader with it, but the build image is on the other hand rather small.
This commit will change the defaults in a way that the LinuxBoot bootloader will actually be able to boot a local or remote system image. In consequence the build payload size is rather big, but accepted for a working out-of-the-box startup behavior.
See discussion on that topic in the above mentioned change.
Signed-off-by: Patrik Tesarik mail@patrik-tesarik.de Change-Id: Ieaba7e523aef10c467a8bea29ae323e22324b225 --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 33 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/40527/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40527
to look at the new patch set (#3).
Change subject: payloads/external/LinuxBoot: Change Kconf defaults ......................................................................
payloads/external/LinuxBoot: Change Kconf defaults
In addition to change I4ac3409040ea77a1836f90f43fba07d2cd05a952 this commit proposes a change of default behavior inside of the LinuxBoot tool chain.
Currently the defaults build a LinuxBoot payload which boots into the U-root shell and waits for input. In fact it does not deliver any bootloader with it, but the build image is on the other hand rather small.
This commit will change the defaults in a way that the LinuxBoot bootloader will actually be able to boot a local or remote system image. In consequence the build payload size is rather big, but accepted for a working out-of-the-box startup behavior.
See discussion on that topic in the above mentioned change.
Signed-off-by: Patrik Tesarik mail@patrik-tesarik.de Change-Id: Ieaba7e523aef10c467a8bea29ae323e22324b225 --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 33 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/40527/3
Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40527 )
Change subject: payloads/external/LinuxBoot: Change Kconf defaults ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40527/1/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Kconfig:
https://review.coreboot.org/c/coreboot/+/40527/1/payloads/external/LinuxBoot... PS1, Line 282: to /bin/uinit. Default: systemboot
trailing whitespace
Ack
https://review.coreboot.org/c/coreboot/+/40527/2/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Kconfig:
https://review.coreboot.org/c/coreboot/+/40527/2/payloads/external/LinuxBoot... PS2, Line 282: to /bin/uinit. Default: systemboot
trailing whitespace
Ack
-
Patrik Tesarik (Code Review)