Attention is currently required from: Felix Held, Marshall Dawson, Matt DeVillier.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84233?usp=email )
Change subject: amdfwtool: Add combo new layout for new family
......................................................................
Patch Set 8:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84233/comment/8cf7d450_4db1f276?usp... :
PS6, Line 1700: ctx.pspdir = NULL;
not done.
Done
https://review.coreboot.org/c/coreboot/+/84233/comment/78e2cbf1_4a6a9a3b?usp... :
PS6, Line 1758: (combo_index == 0 && cb_config.combo_new_rab) ||
: !cb_config.combo_new_rab
not 100% sure if this makes things easier or more difficult to read, but this could be simplified to […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84233?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If573cdeaeb56e95d2fed235c9337fab82d622757
Gerrit-Change-Number: 84233
Gerrit-PatchSet: 8
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 11 Sep 2024 06:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de