Alexander Goncharov has posted comments on this change by Alexander Goncharov. ( https://review.coreboot.org/c/coreboot/+/83282?usp=email )
Change subject: util/ifdtool: dump SPI modes from FLCOMP
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83282/comment/9b324f51_361a9517?usp... :
PS1, Line 9: These fields are documented in the Alder Lake-S Client Platform SPI
: Programming Guide, but they are not presented in the Skylake-LP
: Client Platform SPI Programming Guide
It would be nice if someone who has access to Coffee Lake SPI guide could confirm that these fields […]
It's not really a concern. So mark it as resolved
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I624fe5cb28aa3cb207bc48aa8d31b2a71b70bcf2
Gerrit-Change-Number: 83282
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-CC: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Comment-Date: Thu, 04 Jul 2024 10:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net