Hello Raul Rangel, Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42531
to review the following change.
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
soc/amd/picasso: Set BERT_SIZE to 0 when no table generated
BUG=b:136987699 TEST=Verify no region reserved when CONFIG_ACPI_BERT=n
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I95d511e454e7f2998e46e14112eea5e8b09d59b6 --- M src/soc/amd/picasso/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42531/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index dd5731d..40e3c90 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -331,7 +331,8 @@
config ACPI_BERT_SIZE hex - default 0x4000 + default 0x4000 if ACPI_BERT + default 0x0 help Specify the amount of DRAM reserved for gathering the data used to generate the ACPI table.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42531 )
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
Patch Set 1: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42531 )
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Raul Rangel, Aaron Durbin, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42531
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
soc/amd/picasso: Set BERT_SIZE to 0 when no table generated
BUG=b:136987699 TEST=Verify no region reserved when CONFIG_ACPI_BERT=n
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I95d511e454e7f2998e46e14112eea5e8b09d59b6 --- M src/soc/amd/picasso/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42531/2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42531 )
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42531 )
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
Patch Set 2: Code-Review+1
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42531 )
Change subject: soc/amd/picasso: Set BERT_SIZE to 0 when no table generated ......................................................................
soc/amd/picasso: Set BERT_SIZE to 0 when no table generated
BUG=b:136987699 TEST=Verify no region reserved when CONFIG_ACPI_BERT=n
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I95d511e454e7f2998e46e14112eea5e8b09d59b6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42531 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/soc/amd/picasso/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 9630ad3..2df0b6a 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -327,12 +327,12 @@ depends on HAVE_ACPI_TABLES help Report Machine Check errors identified in POST to the OS in an - ACPI Boot Error Record Table. This option reserves an 8MB region - for building the error structures. + ACPI Boot Error Record Table.
config ACPI_BERT_SIZE hex - default 0x4000 + default 0x4000 if ACPI_BERT + default 0x0 help Specify the amount of DRAM reserved for gathering the data used to generate the ACPI table.
-
Aaron Durbin (Code Review) -
Felix Held (Code Review)
-
Marshall Dawson (Code Review)
-
Paul Menzel (Code Review)