Attention is currently required from: Sathyanarayana Nujella, Varshit B Pandya, Subrata Banik, Furquan Shaikh, Maulik V Vaghela, Paul Menzel, Angel Pons, Ronak Kanabar, Jairaj Arava, Patrick Rudolph.
Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51353 )
Change subject: soc/intel/alderlake: Update iDisp Link UPD settings
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51353/comment/9aa1e8bd_dc2502d8
PS6, Line 7: mb/intel/adlrvp_m
This change is touching more than just mb.
Done. Already changed.
https://review.coreboot.org/c/coreboot/+/51353/comment/65168493_2eb967d7
PS6, Line 9: These UPD values are automatically set by the FSP.
I think it is still safe to configure these in coreboot. […]
from previous platform on, the decision has been made to leave these UPD with their default values and have the FSP and let the FSP assign them.
Please take a loot at CB:40263
https://review.coreboot.org/c/coreboot/+/51353/comment/0b5d4193_42706b63
PS6, Line 10: The explicit settings in coreboot is blocking HDMI/DP audio.
Why is that?
Because the previous value, for T-Mode, manually set in DT turned out to be wrong.
Patchset:
PS7:
Furquain,
Please take a look at the previous/first comments and the referred CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0bf7dc76348f7e184e8496f042badc30bf3211
Gerrit-Change-Number: 51353
Gerrit-PatchSet: 7
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Subrata Banik
subi.banik@gmail.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 30 Mar 2021 03:31:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment