Attention is currently required from: Tarun Tuli, Subrata Banik, Sumeet R Pawnikar, Eric Lai.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )
Change subject: soc/intel/meteoerlake: set power limits dynamically
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74380/comment/a1188a47_78178ea4
PS4, Line 38: { PCI_DID_INTEL_MTL_P_ID_2, MTL_P_282_CORE, TDP_15W },
To my understanding, this database is board specific. It points to settings which are the result of fine tuning factoring information such as the used Voltage Regulator, the particular SoC (number of E-core / P-core), TDP, the overall board design (chips, cooling, ...) along with Power and Performance measurements and tuning on this board design to meet some particular use-cases.
As a result, this database should not be in `soc/intel/meteorlake` but should be somewhere in `mainboard/`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20c9bc21dfa79696b07c460dbcedb4fa51838bdb
Gerrit-Change-Number: 74380
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 20:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment