Attention is currently required from: Xi Chen, Arthur Heymans, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74543 )
Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables
......................................................................
Patch Set 5:
(1 comment)
File src/vendorcode/mediatek/mt8192/include/dramc_common.h:
https://review.coreboot.org/c/coreboot/+/74543/comment/c3b9755d_aeb8a47e
PS5, Line 58: #define msg2(_x_...) { if (0) { print(_x_); } } // { print(_x_); }
The comment can be removed now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic05a9819764c03184b54c4fc58dbe325fddeae10
Gerrit-Change-Number: 74543
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 20 Apr 2023 09:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment