Change in ...coreboot[master]: ec/google/chromeec: fix the error status handling - coreboot-gerrit

26 Feb 2019


      YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 )
Change subject: ec/google/chromeec: fix the error status handling
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31585/2/src/ec/google/chromeec/ec.c 
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/#/c/31585/2/src/ec/google/chromeec/ec.c@598 
PS2, Line 598: !=
...
If we're defining negative integers as error code (as written in the CL description), 'rv < 0' is pr […]
Updated in the new patchsets.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c
Gerrit-Change-Number: 31585
Gerrit-PatchSet: 5
Gerrit-Owner: YH Lin yueherngl@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 01:28:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daisuke Nojiri dnojiri@chromium.org
Gerrit-MessageType: comment