Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85581?usp=email )
Change subject: mb/trulo/var/uldrenite: Configuration serial_io and I2C ......................................................................
Patch Set 4:
(7 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/85581/comment/8b4863c4_68a375a3?usp... : PS2, Line 615: select SOC_INTEL_TWINLAKE
You can remove it. […]
Done
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85581/comment/0d706279_987a05b8?usp... : PS2, Line 96: # FIXME: To be enabled in future based on PNP impact data. : # Disable Package C-state demotion for nissa baseboard. : register "disable_package_c_state_demotion" = "true"
Move to PnP CL
Done
https://review.coreboot.org/c/coreboot/+/85581/comment/96855452_922ec919?usp... : PS2, Line 221: probed
Change it to `detect`
Done
https://review.coreboot.org/c/coreboot/+/85581/comment/a147f9be_e2e12f85?usp... : PS2, Line 237: 280
Same as below
Done
https://review.coreboot.org/c/coreboot/+/85581/comment/0a1a4628_266c01c6?usp... : PS2, Line 255: 300
This is very high. This will impact s0ix suspend/resume time.
Done
https://review.coreboot.org/c/coreboot/+/85581/comment/e5af527e_546fcc43?usp... : PS2, Line 306: device ref heci1 on end
Move to PnP CL
Done
https://review.coreboot.org/c/coreboot/+/85581/comment/cb2f1964_a45638d1?usp... : PS2, Line 314: device ref pmc hidden end
Move to PnP CL
Done
-
John Su (Code Review)