Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34557 )
Change subject: lib: add string.c to verstage ......................................................................
lib: add string.c to verstage
Change-Id: I5aa3bb2c72dcf127d418c989f6b63c9b1f412f08 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/lib/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/34557/1
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 3fad0b8..d16a9f6 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -57,6 +57,7 @@ verstage-y += fmap.c verstage-y += libgcc.c verstage-y += memcmp.c +verstage-y += string.c verstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c verstage-y += boot_device.c verstage-$(CONFIG_CONSOLE_CBMEM) += cbmem_console.c
Hello Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34557
to look at the new patch set (#2).
Change subject: lib: add string.c to verstage ......................................................................
lib: add string.c to verstage
Change-Id: I5aa3bb2c72dcf127d418c989f6b63c9b1f412f08 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/lib/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/34557/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34557 )
Change subject: lib: add string.c to verstage ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34557/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34557/2//COMMIT_MSG@8 PS2, Line 8: Will be used by?
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34557 )
Change subject: lib: add string.c to verstage ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34557 )
Change subject: lib: add string.c to verstage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34557/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34557/2//COMMIT_MSG@8 PS2, Line 8:
Will be used by?
https://review.coreboot.org/c/coreboot/+/33431/8/src/mainboard/google/mistra...
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34557 )
Change subject: lib: add string.c to verstage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34557/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34557/2//COMMIT_MSG@8 PS2, Line 8:
https://review.coreboot.org/c/coreboot/+/33431/8/src/mainboard/google/mistra.... […]
Done
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34557 )
Change subject: lib: add string.c to verstage ......................................................................
lib: add string.c to verstage
Change-Id: I5aa3bb2c72dcf127d418c989f6b63c9b1f412f08 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34557 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Julius Werner jwerner@chromium.org --- M src/lib/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 89ed4b0..7492b16 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -57,6 +57,7 @@ verstage-y += fmap.c verstage-y += libgcc.c verstage-y += memcmp.c +verstage-y += string.c verstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c verstage-y += boot_device.c verstage-$(CONFIG_CONSOLE_CBMEM) += cbmem_console.c
-
Julius Werner (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)