Change in coreboot[master]: src/mb: Use macro for access_size

List overview All Threads
Download

newer

older

Change in coreboot[master]: src:...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

23 Jun 2020 23 Jun '20

7:17 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

src/mb: Use macro for access_size

Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/lenovo/x60/mainboard.c 2 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42728/1

diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c index 509784f..447837b 100644 --- a/src/mainboard/apple/macbook21/mainboard.c +++ b/src/mainboard/apple/macbook21/mainboard.c @@ -17,7 +17,7 @@ .space_id = ACPI_ADDRESS_SPACE_FIXED, .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, - .access_size = 0, + .access_size = ACPI_ACCESS_SIZE_UNDEFINED, .addrl = 0, .addrh = 0, } @@ -30,7 +30,7 @@ .space_id = ACPI_ADDRESS_SPACE_FIXED, .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, - .access_size = 0, + .access_size = ACPI_ACCESS_SIZE_UNDEFINED, .addrl = 0x10, .addrh = 0, } diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c index f88ff00..1623ddc 100644 --- a/src/mainboard/lenovo/x60/mainboard.c +++ b/src/mainboard/lenovo/x60/mainboard.c @@ -20,7 +20,7 @@ .space_id = ACPI_ADDRESS_SPACE_FIXED, \ .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, \ .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, \ - .access_size = 0, \ + .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \ .addrl = (((state) << 4) | (sub_state)), \ .addrh = 0, \ }

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Paul Menzel (Code Review)

25 Jun 25 Jun

8:01 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... PS1, Line 23: .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \ Is the alignment of the \ still correct?

(It also needs clean-up to use tabs consistently for aligning the .)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 25 Jun 2020 08:01:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

26 Jun 26 Jun

10:21 a.m.

Hello build bot (Jenkins), Paul Menzel, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42728

to look at the new patch set (#2).

Change subject: src/mb: Use macro for access_size ......................................................................

src/mb: Use macro for access_size

Also use tabs for aligning the "".

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42728/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

10:22 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... PS1, Line 23: .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \

...

Is the alignment of the \ still correct? […]

Thx. Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 26 Jun 2020 10:22:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

12:28 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... PS1, Line 23: .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \

...

Thx. […]

A separate clean-up commit would have been nice.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 26 Jun 2020 12:28:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

29 Jun 29 Jun

5:57 a.m.

Hello build bot (Jenkins), Paul Menzel, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42728

to look at the new patch set (#3).

Change subject: src/mb: Use macro for access_size ......................................................................

src/mb: Use macro for access_size

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42728/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

5:59 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... File src/mainboard/lenovo/x60/mainboard.c:

https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma... PS1, Line 23: .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \

...

A separate clean-up commit would have been nice.

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 29 Jun 2020 05:59:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Patrick Georgi (Code Review)

30 Jun 30 Jun

5:57 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 30 Jun 2020 05:57:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:57 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42728 )

Change subject: src/mb: Use macro for access_size ......................................................................

src/mb: Use macro for access_size

Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42728 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/lenovo/x60/mainboard.c 2 files changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c index 509784f..447837b 100644 --- a/src/mainboard/apple/macbook21/mainboard.c +++ b/src/mainboard/apple/macbook21/mainboard.c @@ -17,7 +17,7 @@ .space_id = ACPI_ADDRESS_SPACE_FIXED, .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, - .access_size = 0, + .access_size = ACPI_ACCESS_SIZE_UNDEFINED, .addrl = 0, .addrh = 0, } @@ -30,7 +30,7 @@ .space_id = ACPI_ADDRESS_SPACE_FIXED, .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, - .access_size = 0, + .access_size = ACPI_ACCESS_SIZE_UNDEFINED, .addrl = 0x10, .addrh = 0, } diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c index 5210040..f6930bb9 100644 --- a/src/mainboard/lenovo/x60/mainboard.c +++ b/src/mainboard/lenovo/x60/mainboard.c @@ -20,7 +20,7 @@ .space_id = ACPI_ADDRESS_SPACE_FIXED, \ .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, \ .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, \ - .access_size = 0, \ + .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \ .addrl = (((state) << 4) | (sub_state)), \ .addrh = 0, \ }

-- To view, visit https://review.coreboot.org/c/coreboot/+/42728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3 Gerrit-Change-Number: 42728 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1555

days inactive

1562

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)