Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Paul Menzel.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56881 )
Change subject: mb/intel/adlrvp: Update DIMM type as memory down for DDR5 MR SKU
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56881/comment/b0c44201_58c0d89e
PS4, Line 58: case ADL_P_DDR5_2:
shouldn't this go to https://review.coreboot. […]
Done
File src/mainboard/intel/adlrvp/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56881/comment/c1ff64cd_6268acb0
PS2, Line 9: SPD_SOURCES += adlrvp_ddr5_mr # 0b006
Please properly align the comments.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882
Gerrit-Change-Number: 56881
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 11 Aug 2021 14:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment