Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74379 )
Change subject: mb/google/rex/baseboard/rex: Add cpu power limits ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/1953c7d7_fd7d1675 PS1, Line 15: void variant_update_power_limits(const struct cpu_power_limits *limits, size_t num_entries)
this section can be part of power_limit.c. this is the same code like ADL one...
Ack. Created patch https://review.coreboot.org/c/coreboot/+/74620 moving this section to power_limit.c
File src/mainboard/google/rex/variants/rex0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/23e8a802_85dc85d9 PS1, Line 17: variant_update_power_limits
we can call this directly from systemagent.c. no need hook up from variant_devtree_update. […]
I feel we need this here for variants to set during ramstage.
-
Sumeet R Pawnikar (Code Review)