Change in coreboot[master]: mainboard/amd: Remove AMD Torpedo mainboard

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Name of user not set (Code Review)

20 Oct 2019 20 Oct '19

5:11 p.m.

awokd@danwin1210.me has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

mainboard/amd: Remove AMD Torpedo mainboard

This also permits removal of vc/amd/agesa/f12, as it was the only mainboard using it. That will in turn allow resolving some unique Coverity issues reported against that source.

Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Signed-off-by: Joe Moore awokd@danwin1210.me --- D src/mainboard/amd/torpedo/BiosCallOuts.c D src/mainboard/amd/torpedo/Kconfig D src/mainboard/amd/torpedo/Kconfig.name D src/mainboard/amd/torpedo/Makefile.inc D src/mainboard/amd/torpedo/Oem.h D src/mainboard/amd/torpedo/OemCustomize.c D src/mainboard/amd/torpedo/OptionsIds.h D src/mainboard/amd/torpedo/acpi/ide.asl D src/mainboard/amd/torpedo/acpi/routing.asl D src/mainboard/amd/torpedo/acpi/sata.asl D src/mainboard/amd/torpedo/acpi/usb.asl D src/mainboard/amd/torpedo/acpi_tables.c D src/mainboard/amd/torpedo/board_info.txt D src/mainboard/amd/torpedo/buildOpts.c D src/mainboard/amd/torpedo/cmos.layout D src/mainboard/amd/torpedo/devicetree.cb D src/mainboard/amd/torpedo/dsdt.asl D src/mainboard/amd/torpedo/fadt.c D src/mainboard/amd/torpedo/gpio.c D src/mainboard/amd/torpedo/gpio.h D src/mainboard/amd/torpedo/irq_tables.c D src/mainboard/amd/torpedo/mainboard.c D src/mainboard/amd/torpedo/mptable.c D src/mainboard/amd/torpedo/platform_cfg.h D src/mainboard/amd/torpedo/pmio.h D src/mainboard/amd/torpedo/romstage.c 26 files changed, 0 insertions(+), 7,601 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36173/1

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Kyösti Mälkki (Code Review)

20 Oct 20 Oct

9:06 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 1 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 20 Oct 2019 21:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

27 Oct 27 Oct

10:38 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

Patch Set 1: Code-Review-2

Again, I absolutely agree with doing this, I just want to wait until after the next coreboot release, when this change can be merged immediately. I believe that release should happen in roughly 3 weeks.

Please update the release notes saying that AMD family 12h will be removed after this release.

https://review.coreboot.org/cgit/coreboot.git/tree/Documentation/releases/co...

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 1 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 27 Oct 2019 22:38:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Name of user not set (Code Review)

28 Oct 28 Oct

1:49 p.m.

awokd@danwin1210.me has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

Patch Set 1:

...

Patch Set 1: Code-Review-2

Again, I absolutely agree with doing this, I just want to wait until after the next coreboot release, when this change can be merged immediately. I believe that release should happen in roughly 3 weeks.

Please update the release notes saying that AMD family 12h will be removed after this release.

https://review.coreboot.org/cgit/coreboot.git/tree/Documentation/releases/co...

https://review.coreboot.org/c/coreboot/+/36405

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 1 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Oct 2019 13:49:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

19 Nov 19 Nov

4:49 p.m.

Patrick Georgi has uploaded a new patch set (#2) to the change originally created by awokd@danwin1210.me. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

mainboard/amd: Remove AMD Torpedo mainboard

This also permits removal of vc/amd/agesa/f12, as it was the only mainboard using it. That will in turn allow resolving some unique Coverity issues reported against that source.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36173/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 2 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Martin Roth (Code Review)

20 Nov 20 Nov

1:19 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

Patch Set 2: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 2 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Nov 2019 13:19:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

1:21 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 2 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Nov 2019 13:21:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1:22 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36173 )

Change subject: mainboard/amd: Remove AMD Torpedo mainboard ......................................................................

mainboard/amd: Remove AMD Torpedo mainboard

This also permits removal of vc/amd/agesa/f12, as it was the only mainboard using it. That will in turn allow resolving some unique Coverity issues reported against that source.

Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Signed-off-by: Joe Moore awokd@danwin1210.me Reviewed-on: https://review.coreboot.org/c/coreboot/+/36173 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- D src/mainboard/amd/torpedo/BiosCallOuts.c D src/mainboard/amd/torpedo/Kconfig D src/mainboard/amd/torpedo/Kconfig.name D src/mainboard/amd/torpedo/Makefile.inc D src/mainboard/amd/torpedo/Oem.h D src/mainboard/amd/torpedo/OemCustomize.c D src/mainboard/amd/torpedo/OptionsIds.h D src/mainboard/amd/torpedo/acpi/ide.asl D src/mainboard/amd/torpedo/acpi/routing.asl D src/mainboard/amd/torpedo/acpi/sata.asl D src/mainboard/amd/torpedo/acpi/usb.asl D src/mainboard/amd/torpedo/acpi_tables.c D src/mainboard/amd/torpedo/board_info.txt D src/mainboard/amd/torpedo/buildOpts.c D src/mainboard/amd/torpedo/cmos.layout D src/mainboard/amd/torpedo/devicetree.cb D src/mainboard/amd/torpedo/dsdt.asl D src/mainboard/amd/torpedo/fadt.c D src/mainboard/amd/torpedo/gpio.c D src/mainboard/amd/torpedo/gpio.h D src/mainboard/amd/torpedo/irq_tables.c D src/mainboard/amd/torpedo/mainboard.c D src/mainboard/amd/torpedo/mptable.c D src/mainboard/amd/torpedo/platform_cfg.h D src/mainboard/amd/torpedo/pmio.h D src/mainboard/amd/torpedo/romstage.c 26 files changed, 0 insertions(+), 7,589 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/36173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f570f01fcb5ba0e306508a569ea97f432596b3 Gerrit-Change-Number: 36173 Gerrit-PatchSet: 3 Gerrit-Owner: awokd@danwin1210.me Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: awokd@danwin1210.me Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1775

days inactive

1806

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Kyösti Mälkki (Code Review)
Martin Roth (Code Review)
Name of user not set (Code Review)
Patrick Georgi (Code Review)