Change in coreboot[master]: decompressor: Add CBFS_VERIFICATION support - coreboot-gerrit

5 Apr 2021


      Attention is currently required from: Martin Roth, Furquan Shaikh, Julius Werner.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52085 )
Change subject: decompressor: Add CBFS_VERIFICATION support
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/lib/metadata_hash.c:
https://review.coreboot.org/c/coreboot/+/52085/comment/5c3e0a2a_bfacd203 
PS1, Line 33: 	return &anchor_ptr->cbfs_hash;
I know it's not likely (and much badness would have to occur), but do you think it's worth doing checks on anchor_ptr == NULL?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52085
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e6d7384cfb8339a24369eb6c01fc12f911c974e
Gerrit-Change-Number: 52085
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Mon, 05 Apr 2021 20:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment