Attention is currently required from: Rex-BC Chen, Yu-Ping Wu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60002 )
Change subject: mb/google/corsola: set up open-drain ChromeOS pins
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/corsola/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135293):
https://review.coreboot.org/c/coreboot/+/60002/comment/a92ed9be_6b38a6d2
PS3, Line 25: #define GPIO_XHCI_DONE GPIO(PERIPHERAL_EN1)
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib55a773bb63404a1b952f7e7645eb7aba6638b00
Gerrit-Change-Number: 60002
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 10 Dec 2021 02:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment