Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43005 )
Change subject: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear on RTC failure ......................................................................
Patch Set 8:
(8 comments)
https://review.coreboot.org/c/coreboot/+/43005/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43005/7//COMMIT_MSG@7 PS7, Line 7: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear when RTC failure is detected
Maybe below summary is shorter: […]
Done
https://review.coreboot.org/c/coreboot/+/43005/7//COMMIT_MSG@9 PS7, Line 9: When RTC failure is detected, : send IPMI OEM command to issue CMOS clear. : This is to let the payload (LinuxBoot) do some handling.
Please re-flow for 75 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... PS7, Line 16: #define VALID_BIT (1 << 7)
Please align the values with spaces to the column of the block above.
Done
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... PS7, Line 19: #define IS_CMOS_AND_VALID_BIT(x) ((x)&CMOS_BIT && (x)&VALID_BIT)
I’d left align the names.
Done
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.c:
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... PS7, Line 122: the CMOS clear bit are both set from the response BootMode byte. */
Please align to the word *IPMI* above.
Done
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... PS7, Line 136:
Pleas remove the blank line.
Done
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... PS7, Line 150: printk(BIOS_INFO, "IPMI CMOS clear requested\n");
Maybe elaborate: … because CMOS data is invalid.
Done
https://review.coreboot.org/c/coreboot/+/43005/7/src/mainboard/ocp/deltalake... PS7, Line 151: return CB_SUCCESS;
Please add a blank line above.
Done