New patch to review for coreboot: asus/f2a85-m: Enable IOMMU (again!)

[Damien Zammit]

Damien Zammit ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11154

-gerrit

commit 8937b6753bd36180af327884d1114ea2fcf8b3c2
Author: Damien Zammit 
Date:   Mon Aug 10 23:50:03 2015 +1000

asus/f2a85-m: Enable IOMMU (again!)

There were some issues previously when the IOMMU was enabled
    on this board such as linux io page errors and compile errors.
    (See Change-Id I0aa530be17d )

I built coreboot with this patch today, flashed it to my board
    and it boots.  Not only that but I didn't see any problems in
    linux dmesg and I was able to use kvm pci passthrough using the IOMMU.

$ dmesg|grep AMD-Vi
    [    0.718814] AMD-Vi: Applying erratum 746 workaround for IOMMU at 0000:00:00.2
    [    0.719407] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
    [    0.719409] AMD-Vi:  Extended features:  PreF PPR GT IA
    [    0.719412] AMD-Vi: Interrupt remapping enabled
    [    0.731430] AMD-Vi: Lazy IO/TLB flushing enabled

$ lspci -s 0.2
    00:00.2 IOMMU: Advanced Micro Devices, Inc. [AMD] Family 15h (Models 10h-1fh) I/O Memory Management Unit

Change-Id: Idbd1ff8362731752af1fa5bd267f13d6dc821c52
    Signed-off-by: Damien Zammit 
---
 src/mainboard/asus/f2a85-m/buildOpts.c   | 2 +-
 src/mainboard/asus/f2a85-m/devicetree.cb | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c
index b812cd5..3c9371c 100644
--- a/src/mainboard/asus/f2a85-m/buildOpts.c
+++ b/src/mainboard/asus/f2a85-m/buildOpts.c
@@ -181,7 +181,7 @@
 #define BLDCFG_UMA_ABOVE4G_SUPPORT                FALSE
 #endif

-#define BLDCFG_IOMMU_SUPPORT    FALSE
+#define BLDCFG_IOMMU_SUPPORT    TRUE

#define BLDCFG_CFG_GNB_HD_AUDIO TRUE
 //#define BLDCFG_IGPU_SUBSYSTEM_ID            OEM_IGPU_SSID
diff --git a/src/mainboard/asus/f2a85-m/devicetree.cb b/src/mainboard/asus/f2a85-m/devicetree.cb
index 4562557..b501dc2 100644
--- a/src/mainboard/asus/f2a85-m/devicetree.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree.cb
@@ -30,6 +30,7 @@ chip northbridge/amd/agesa/family15tn/root_complex

chip northbridge/amd/agesa/family15tn # PCI side of HT root complex
    			device pci 0.0 on  end # Root Complex
+				device pci 0.2 on  end # IOMMU
    			device pci 1.0 on  end # Internal Graphics P2P bridge 0x99XX
    			device pci 1.1 on  end # Internal Multimedia
    			device pci 2.0 on  end # PCIE SLOT0 x16 blue