Attention is currently required from: Tim Wawrzynczak, Robert Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting ......................................................................
Patch Set 7:
(8 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/f7d883a9_387e9bd8 PS7, Line 72: (config->boost_peak_milliamp % 50)){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/5e541b27_f1efbb6c PS7, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/f384abbb_49aa2248 PS7, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/2e447e2d_acf80385 PS7, Line 85: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/8ac3d413_5e3ddf2e PS7, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/904cd0f3_3b41acd8 PS7, Line 108: if (config->name){ suspect code indent for conditional statements (0, 0)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/f2be7c1a_d7fa2f16 PS7, Line 108: if (config->name){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136609): https://review.coreboot.org/c/coreboot/+/60331/comment/a255c018_e286746b PS7, Line 108: if (config->name){ braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)