Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64009 )
Change subject: nb/amd/agesa/family14: Clean up fx_devs stuff
......................................................................
Patch Set 1: Code-Review+1
(4 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/64009/comment/28d5e83a_e669ef95
PS1, Line 78: if (fx_devs == 0)
Not needed anymore.
https://review.coreboot.org/c/coreboot/+/64009/comment/c0201d31_7bca1f0d
PS1, Line 86: if (fx_devs == 0)
Dito.
https://review.coreboot.org/c/coreboot/+/64009/comment/06597493_0f22ee30
PS1, Line 88: for (i = 0; i < fx_devs; i++) {
Also not needed anymore.
https://review.coreboot.org/c/coreboot/+/64009/comment/50d6b2d9_89468fd1
PS1, Line 460: base = f1_read_config32(reg);
: limit = f1_read_config32(reg + 0x04);
NB. When were these written?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8475d42627c48336c98afdfe659f3bbfb173c3c
Gerrit-Change-Number: 64009
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 04 May 2022 10:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment