Change in coreboot[master]: sb/intel/bd82x6x: Skip ME init when MEI #1 is disabled - coreboot-gerrit

27 Jan 2021


      Attention is currently required from: Evgeny Zinoviev, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49995 )
Change subject: sb/intel/bd82x6x: Skip ME init when MEI #1 is disabled
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/49995/comment/c2894710_b87daa37 
PS1, Line 180: pci_read_config16
...
the __pci_driver already takes care of this pre check
Somehow, this function was running when the PCI config space was inaccessible. I didn't test too much, but I suspect bad things happen when hiding MEI #2.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee04da2c9f7edf41f8c70398e0f49eb8b877e6d1
Gerrit-Change-Number: 49995
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Evgeny Zinoviev me@ch1p.io
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 27 Jan 2021 19:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment