Change in coreboot[master]: drivers/uart: Add ACPI SPCR table generation - coreboot-gerrit

19 Jan 2021


      Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49317 )
Change subject: drivers/uart: Add ACPI SPCR table generation
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: 
the acpi spcr table lacks a field for the uart base clock; for legacy i/o mapped uarts the ~1.8mhz base clock is a relatively valid assumption, but for mmio mapped uarts this assumption can't be made. see drivers/acpi/acpi_apd.c in linux
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e7c17adcf5b2a8206a8308e057855819ec413a
Gerrit-Change-Number: 49317
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Tue, 19 Jan 2021 16:44:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment