Change in coreboot[master]: soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX

[Christian Walter (Code Review)]

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45869 )

Change subject: soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX
......................................................................

soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX

Change-Id: Ib329648f77acecccb0ced1806f61be252d03f2f4
Signed-off-by: Christian Walter 
---
M src/soc/intel/xeon_sp/cpx/cpu.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45869/1

diff --git a/src/soc/intel/xeon_sp/cpx/cpu.c b/src/soc/intel/xeon_sp/cpx/cpu.c
index eb8c0eb..0999f6d 100644
--- a/src/soc/intel/xeon_sp/cpx/cpu.c
+++ b/src/soc/intel/xeon_sp/cpx/cpu.c
@@ -16,6 +16,7 @@
 #include <soc/msr.h>
 #include <soc/soc_util.h>
 #include "chip.h"
+#include <cpu/intel/common/common.h>

static const void *microcode_patch;

@@ -91,6 +92,9 @@

/* Clear out pending MCEs */
    xeon_configure_mca();
+
+	/* Enable Vmx */
+	set_vmx_and_lock();
 }

static struct device_operations cpu_dev_ops = {

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45869 )

Change subject: soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX
......................................................................

Patch Set 3: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45869 )

Change subject: soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX
......................................................................

Patch Set 4: Code-Review+2

FSP also has an UPD for VmxEnable or EnableVmx which should be set as well, using the Kconfig setting

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45869 )

Change subject: soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX
......................................................................

soc/intel/xeon_sp/cpx: Add locking of IA32_FEATURE_CONTROL and VMX

Change-Id: Ib329648f77acecccb0ced1806f61be252d03f2f4
Signed-off-by: Christian Walter 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45869
Reviewed-by: Angel Pons 
Reviewed-by: Patrick Rudolph 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/xeon_sp/cpx/cpu.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/xeon_sp/cpx/cpu.c b/src/soc/intel/xeon_sp/cpx/cpu.c
index eb8c0eb..0999f6d 100644
--- a/src/soc/intel/xeon_sp/cpx/cpu.c
+++ b/src/soc/intel/xeon_sp/cpx/cpu.c
@@ -16,6 +16,7 @@
 #include <soc/msr.h>
 #include <soc/soc_util.h>
 #include "chip.h"
+#include <cpu/intel/common/common.h>

static const void *microcode_patch;

@@ -91,6 +92,9 @@

/* Clear out pending MCEs */
    xeon_configure_mca();
+
+	/* Enable Vmx */
+	set_vmx_and_lock();
 }

static struct device_operations cpu_dev_ops = {