Attention is currently required from: Furquan Shaikh, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58158 )
Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58158/comment/9779e762_4a9cf6cc
PS7, Line 585: cbfs_rw_version.major = skip_atoi(&ptr);
: ptr++;
: cbfs_rw_version.minor = skip_atoi(&ptr);
: ptr++;
: cbfs_rw_version.hotfix = skip_atoi(&ptr);
: ptr++;
: cbfs_rw_version.build = skip_atoi(&ptr);
should there be error checking here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d
Gerrit-Change-Number: 58158
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 08 Oct 2021 16:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment