Attention is currently required from: Robert Zieba, Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74658 )
Change subject: soc/amd/phoenix/include/xhci: add USB4 XHCI device pointers
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74658/comment/7932ae92_a215475f
PS2, Line 9: Beware that there's no XHCI2 controller and the USB4 controller device
: pointers were added right after the xhci_0 and xhci_1 controller device
: pointers.
Maybe say why? Should a similar comment be added to the source file? Nobody's going to look at the […]
Definitely agree with Martin. I started looking into why it was not added to SOC_XHCI_3/4 similar to SMI/SCI map. Then later found that saving of XHCI PCI resources does not expect a hole in the list of XHCI devices. From that standpoint a comment is really helpful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14725d4b546ffcca42e21bbe7756babaaff8fea3
Gerrit-Change-Number: 74658
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Apr 2023 16:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment