Change in coreboot[master]: soc/intel/common: Calculate and configure SF Mask 2 - coreboot-gerrit

2 Aug 2021


      Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56717 )
Change subject: soc/intel/common: Calculate and configure SF Mask 2
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/56717/comment/3a054bb8_673ba2c4 
PS1, Line 540: mov	%ebx, %eax /* restore data_ways in eax */
             : 	xorl	%edx, %edx
             : 	mov	$IA32_CR_SF_QOS_MASK_2, %ecx
             : 	wrmsr
...
...
Yes, i hope comment at line 527 is helpful to set this expectation. […]
Done, thanks
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56717
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I442bed75f13d26f357cfb32c54c5fe9efa4b474b
Gerrit-Change-Number: 56717
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 02 Aug 2021 07:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment