Attention is currently required from: Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62709 )
Change subject: commonlib/timestamp_serialized: Add timestamp enum to name mapping ......................................................................
Patch Set 4:
(8 comments)
File src/commonlib/include/commonlib/timestamp_serialized.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/cc0ee96b_8bc22b67 PS4, Line 171: #define ts_enum_name_pair(e) e, XSTR(e) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/9f310ca9_b0e6c4b6 PS4, Line 225: { ts_enum_name_pair(TS_VERIFY_SLOT_START), "starting to verify keyblock/preamble (RSA)" }, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/766c1b9b_c769af69 PS4, Line 237: { ts_enum_name_pair(TS_EC_POWER_LIMIT_WAIT), "waiting for EC to allow higher power draw" }, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/f2731a35_b9927e95 PS4, Line 272: { ts_enum_name_pair(TS_ME_INFORM_DRAM_START), "waiting for ME acknowledgement of raminit"}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/3d25901c_8b1f94e8 PS4, Line 279: { ts_enum_name_pair(TS_ME_RECEIVED_CRDA_FROM_PMC), "CSE received 'CPU Reset Done Ack sent' from PMC"}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/dbaab9c3_6c228123 PS4, Line 291: { ts_enum_name_pair(TS_FSP_MULTI_PHASE_SI_INIT_END), "returning from FspMultiPhaseSiInit" }, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/c47dd75e_bf285fb4 PS4, Line 318: { ts_enum_name_pair(TS_VB_STORAGE_INIT_DONE), "finished storage device initialization" }, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143909): https://review.coreboot.org/c/coreboot/+/62709/comment/588641fd_d302bc30 PS4, Line 323: { ts_enum_name_pair(TS_KERNEL_DECOMPRESSION), "starting kernel decompression/relocation" }, line over 96 characters