Attention is currently required from: Nick Vaccaro, Pavan Holla, Shelley Chen.
Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email )
Change subject: ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled
......................................................................
Patch Set 7:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/81967/comment/af2bd12f_ef2be6e9 :
PS7, Line 729: uint32_t cc
Do you want to define cc as union ec_common_control? Then, you can call cbi_get_uint32:
rv = cbi_get_uint32(&cc.raw_value, CBI_TAG_COMMON_CONTROL);
and change line 746 to:
*ucsi_enabled = cc.ucsi_enabled;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81967?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67dff6445aa7ba3ba48a04d1df3541f880d09d0a
Gerrit-Change-Number: 81967
Gerrit-PatchSet: 7
Gerrit-Owner: Pavan Holla
pholla@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Forest Mittelberg
bmbm@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Pavan Holla
pholla@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 18 Apr 2024 21:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment