Change in coreboot[master]: console: Allow VPD to disable an otherwise enabled coreboot console
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45208 )
Change subject: console: Allow VPD to disable an otherwise enabled coreboot console ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45208/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45208/4//COMMIT_MSG@18 PS4, Line 18: entry is added.
Yes, I meant an ELF section. And you are right, compression probably makes […]
Yes, the VPD solution may be less bad on x86. Kinda depends on caching details I'm not super familiar with. The general problem with the VPD code (other than just being somewhat big in general) is that it always reloads the whole VPD in every stage... if x86 flash controllers will cache accesses to the same region across all stages, maybe that's less of a problem there. But I'm still not feeling great about standardizing that as an option available everywhere when it only works well on some platforms and the reasons are not very obvious.
I don't know what Patrick intended here, I just saw it uploaded and felt like I should -1. ;) The earlier discussions on the same topic looked like the people who want it use x86 platforms to me.
-
Julius Werner (Code Review)