[L] Change in coreboot[main]: mb/google/fatcat: add pre-mem GPIO pad configure based on fw_config

[Subrata Banik (Code Review)]

Attention is currently required from: Cliff Huang, Jérémy Compostella.

Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84718?usp=email )

Change subject: mb/google/fatcat: add pre-mem GPIO pad configure based on fw_config
......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84718/comment/371c2721_994b2137?usp... :
PS4, Line 7: dd pre-mem GPIO pad configure based on fw_config
> I am confused, we followed https://review.coreboot.org/c/coreboot/+/84718/comments/0401046a_46026bbd and as a result we pulled a bit from overridetree.cb to satisfy your request.

My original request was to add the FW_CONFIG for pre-mem and get this CL landed ASAP. After that, we can add minimal override devicetree changes along with FW_CONFIG for advanced devices. We can always add devicetree/GPIO for ramstage incrementally. I never suggested pulling changes from CB:84408 to CB:84718.
> The commit message still is about configuring GPIO based on fw_config but having these changes without the device which go away do not make sense.

ideally we add three changes together for any IP/device block

1. FW config
2. override tree
3. corresponding GPIO override using FW config

Looking at CB:84718, I felt this CL was previously intended to perform early GPIO programming as per FW config and override tree was never the goal. Override tree was added with CB:84408 CL.
> Do you mean we should add a line stating that we are also providing the devicetree information for the relevant devices ?

yes, as you have added both override tree and GPIO changes for pre-ram depending upon the FW config, you should mention the same rather saying this CL is just for pre-mem GPIO configuration based on FW config