David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29744 )
Change subject: util/cbfstool: Add optional argument ibb
......................................................................
Patch Set 20: Code-Review-1
(3 comments)
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c@4...
PS20, Line 453: const bool ibb)
Let's use param.ibb directly instead of adding more cruft to this function signature.
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c@5...
PS20, Line 548: ibb
param.ibb
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c@1...
PS20, Line 1279: O
Bikeshedding time: 'O' seems like an awkward choice. I'm trying to think of a letter that can describe this thing better... Maybe 'B' for boot block or 'I' for initial boot block?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29744
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4857c894b9ee1edc464c0a1216cdda29937bbd
Gerrit-Change-Number: 29744
Gerrit-PatchSet: 20
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jens Drenhaus
jens.drenhaus@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kai Michaelis
kai.michaelis@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Aug 2019 09:57:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment