Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Guangjie Song has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84495?usp=email )
Change subject: soc/mediatek/mt8196: Add PLL and Clock init support
......................................................................
Patch Set 26:
(1 comment)
File src/soc/mediatek/mt8196/pll.c:
https://review.coreboot.org/c/coreboot/+/84495/comment/85bf3d2d_47c3f29e?usp... :
PS13, Line 1196: 30
@guangjie.song@mediatek.corp-partner.google.com […]
"cg_idx" is pre-assigned and has a 1:1 mapping relationship with the clock control register. Values of cg_idx beyond 30 are not mapped to specific clock control registers, so they have no practical significance and therefore no macros are defined to match them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icac99fb210c87c8b7b14af627fbd2f14e4c47240
Gerrit-Change-Number: 84495
Gerrit-PatchSet: 26
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 04 Nov 2024 01:58:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Comment-In-Reply-To: Jarried Lin
jarried.lin@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com