Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54923 )
Change subject: soc/amd/common/block: Add irq_override flags
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/chip.h:
https://review.coreboot.org/c/coreboot/+/54923/comment/50718dff_1cbe49d2
PS1, Line 45: uint8_t flags;
wouldn't it be a good idea to use an enum here?
They are flags that are `|` together. I could add a `trigger` and `polarity` property instead, though that's a bigger refactor.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6f44d4ef4b7bb7398e173f42269e4fa833b545c
Gerrit-Change-Number: 54923
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 10 Feb 2022 20:52:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment