Attention is currently required from: Raul Rangel, Jason Glenesk, Martin Roth, Tim Van Patten, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74334 )
Change subject: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/soc/amd/mendocino/Kconfig:
https://review.coreboot.org/c/coreboot/+/74334/comment/7cf4dad9_72dd7eba
PS1, Line 246: SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA
Should this be CBFS_PRELOAD || SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie30b6324f9977261c60e55ed509e979ef290f1f1
Gerrit-Change-Number: 74334
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 11 Apr 2023 22:49:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment