[XL] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M920q (Cannon Lake) - coreboot-gerrit

8 May 2024


      Attention is currently required from: Alexander Couzens, Angel Pons, Maciej Pijanowski, Paul Menzel.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Cannon Lake)
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/lenovo/m920q/romstage.c:
https://review.coreboot.org/c/coreboot/+/80609/comment/17c44d14_a276875f :
PS6, Line 33: 	/* Rcomp target values for CFL-S, DDR4 and 2 DIMMs per channel */
...
Ah, I remember a bit more: this number is read ODT, and it gets trained by MRC anyway. […]
Okay, if it's not an issue, I have no problem marking this as done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80609?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea1dc5745c0ecf687fa18b793f0aab4b0855d6d4
Gerrit-Change-Number: 80609
Gerrit-PatchSet: 7
Gerrit-Owner: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com
Gerrit-Attention: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 08 May 2024 12:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Michał Kopeć michal.kopec@3mdeb.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment