Attention is currently required from: Felix Singer, Patrick Rudolph, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70295 )
Change subject: mb/hp/z220_series: Drop VBOOT support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
What's the benefit here? I don't understand the problem. […]
The original goal is to deprecate VBOOT_VBNV_CMOS and replace with VBOOT_VBNV_FLASH. However, when I tried to enable VBOOT for HP_Z220_CMT_WORKSTATION (by `select VBOOT` for BOARD_HP_Z220_SERIES_COMMON), the build failed:
E: Image is missing 'GBB' region
The problem is that the board doesn't even have a valid .fmd file for VBOOT. For VBOOT to work the GBB and RW regions must exist. Therefore I just think VBOOT was never supported from the very first.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dcabda5e8ee3a0084736d3674dca31d1f5a641f
Gerrit-Change-Number: 70295
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 06 Jan 2023 03:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment