[S] Change in coreboot[main]: soc/intel: fix slp-s0 residency counter frequency _lpit table

[Jakub Czapiga (Code Review)]

Attention is currently required from: Eran Mitrani, Jérémy Compostella, Subrata Banik, Sukumar Ghorai, Tarun.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78164?usp=email )

Change subject: soc/intel: fix slp-s0 residency counter frequency _lpit table
......................................................................

Patch Set 3:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/78164/comment/3d1ac04f_e4f06faa :
PS3, Line 7: fix
super-nit: `Fix`

https://review.coreboot.org/c/coreboot/+/78164/comment/b08924d8_55e68e4a :
PS3, Line 7: _lpit
If I recall correctly ACPI tables use 4 characters for their names, to it would be `"LPIT"` instead of `_lpit`.

https://review.coreboot.org/c/coreboot/+/78164/comment/594cb1ce_c5259561 :
PS3, Line 9:  using
`use`

https://review.coreboot.org/c/coreboot/+/78164/comment/779d13b8_8c0b26c0 :
PS3, Line 10: Two types of low power residencies
`There are two types of low power residencies`

https://review.coreboot.org/c/coreboot/+/78164/comment/b13fb146_6aa82efe :
PS3, Line 12: memory mapped
Please correct this line with `memory mapped <what?>` or use `MMIO` instead.

https://review.coreboot.org/c/coreboot/+/78164/comment/62f6d497_fec6d6cb :
PS3, Line 16:  measured
`is measured`

File src/soc/intel/common/block/acpi/lpit.c:

https://review.coreboot.org/c/coreboot/+/78164/comment/757657b7_e85c07b2 :
PS3, Line 34: MSR value return in usec
Can you elaborate and also extend this comment with more detailed description?

https://review.coreboot.org/c/coreboot/+/78164/comment/4d0be37a_73715b03 :
PS3, Line 34: 0;
Why set it to zero per package and leave it as config value in SLP_S0 only?

File src/soc/intel/meteorlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/78164/comment/cf71dce5_5f24a432 :
PS3, Line 446: tick
Did you mean `ticks`?