Change in coreboot[master]: soc/qualcomm/common: Update helper function to know size of memchipinfo - coreboot-gerrit

12 Apr 2022


      Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: Update helper function to know size of memchipinfo
......................................................................
Patch Set 10:
(2 comments)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/e34d5289_af76a143 
PS10, Line 28: te->size
Please align with te->size above.
https://review.coreboot.org/c/coreboot/+/63026/comment/1737152f_3145165c 
PS10, Line 29: local
Isn't mem_chip_addr a global variable?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63026
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d59669adaf287d0eb7b58ccb0fe3f98e3d23281
Gerrit-Change-Number: 63026
Gerrit-PatchSet: 10
Gerrit-Owner: Ravi Kumar Bokka rbokka@codeaurora.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Ravi Kumar Bokka rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 12 Apr 2022 07:06:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment