Attention is currently required from: Alicja Michalska, Andrey Petrov, Angel Pons, Benjamin Doron, Jeremy Compostella, Jérémy Compostella, Ronak Kanabar, Subrata Banik.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/84833?usp=email )
Change subject: arch/x86: Add breakpoint to stack canary
......................................................................
Patch Set 19:
(1 comment)
File src/arch/x86/stack_canary_breakpoint.c:
https://review.coreboot.org/c/coreboot/+/84833/comment/e6ce6e98_cc3e5fe8?usp... :
PS9, Line 52: disable
I think this is done for consistency with `null_breakpoint`. […]
Done in https://review.coreboot.org/c/coreboot/+/85540/1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84833?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8adf07a8425856795a4a71da5c41bec2244b02a8
Gerrit-Change-Number: 84833
Gerrit-PatchSet: 19
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 14:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com