Attention is currently required from: Michał Żygowski, Maxim Polyakov, Michał Kopeć.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63403 )
Change subject: util/intelp2m: Add support for Alder Lake H macro generation
......................................................................
Patch Set 2:
(2 comments)
File util/intelp2m/description.md:
https://review.coreboot.org/c/coreboot/+/63403/comment/8d5b681a_d461100c
PS1, Line 39: AlderLake-H
From a quick look at Intel docs #618659 and #627075 The GPIO functions are different, the communiti […]
Hmmm, if "cnl" works for both PCH-H and PCH-LP, I don't see why it would be necessary to handle ADL PCH-H separately from ADL PCH-LP.
File util/intelp2m/platforms/adlh/macro.go:
https://review.coreboot.org/c/coreboot/+/63403/comment/1b9402b8_07d0b910
PS2, Line 20: MAX_DW_NUM = common.MAX_DW_NUM
According to coreboot code, ADL GPIOs have 4 DW registers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5871394bcb0636c2c803607ffb129441aa934417
Gerrit-Change-Number: 63403
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 08:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-MessageType: comment