Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42636 )
Change subject: sb/intel/i82801{ix,jx}/hdaudio.c: Drop unused typedef ......................................................................
sb/intel/i82801{ix,jx}/hdaudio.c: Drop unused typedef
Tested with BUILD_TIMELESS=1, Roda RK9 does not change.
Change-Id: I9967d625a8e6d2e1063b9b38965d81a466738964 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/i82801ix/hdaudio.c M src/southbridge/intel/i82801jx/hdaudio.c 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/42636/1
diff --git a/src/southbridge/intel/i82801ix/hdaudio.c b/src/southbridge/intel/i82801ix/hdaudio.c index 6f82cb4..2633d0b 100644 --- a/src/southbridge/intel/i82801ix/hdaudio.c +++ b/src/southbridge/intel/i82801ix/hdaudio.c @@ -15,8 +15,6 @@ #define HDA_ICII_BUSY (1 << 0) #define HDA_ICII_VALID (1 << 1)
-typedef struct southbridge_intel_i82801ix_config config_t; - static int set_bits(void *port, u32 mask, u32 val) { u32 reg32; diff --git a/src/southbridge/intel/i82801jx/hdaudio.c b/src/southbridge/intel/i82801jx/hdaudio.c index 1ff9e05..71ea214 100644 --- a/src/southbridge/intel/i82801jx/hdaudio.c +++ b/src/southbridge/intel/i82801jx/hdaudio.c @@ -15,8 +15,6 @@ #define HDA_ICII_BUSY (1 << 0) #define HDA_ICII_VALID (1 << 1)
-typedef struct southbridge_intel_i82801jx_config config_t; - static int set_bits(void *port, u32 mask, u32 val) { u32 reg32;
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42636
to look at the new patch set (#2).
Change subject: sb/intel/i82801{gx,ix,jx}/hdaudio.c: Drop unused typedef ......................................................................
sb/intel/i82801{gx,ix,jx}/hdaudio.c: Drop unused typedef
Tested with BUILD_TIMELESS=1, Roda RK9 does not change.
Change-Id: I9967d625a8e6d2e1063b9b38965d81a466738964 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/i82801gx/azalia.c M src/southbridge/intel/i82801ix/hdaudio.c M src/southbridge/intel/i82801jx/hdaudio.c 3 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/42636/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42636 )
Change subject: sb/intel/i82801{gx,ix,jx}/hdaudio.c: Drop unused typedef ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42636 )
Change subject: sb/intel/i82801{gx,ix,jx}/hdaudio.c: Drop unused typedef ......................................................................
sb/intel/i82801{gx,ix,jx}/hdaudio.c: Drop unused typedef
Tested with BUILD_TIMELESS=1, Roda RK9 does not change.
Change-Id: I9967d625a8e6d2e1063b9b38965d81a466738964 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42636 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/southbridge/intel/i82801ix/hdaudio.c M src/southbridge/intel/i82801jx/hdaudio.c 2 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801ix/hdaudio.c b/src/southbridge/intel/i82801ix/hdaudio.c index 9e94537..93a3947 100644 --- a/src/southbridge/intel/i82801ix/hdaudio.c +++ b/src/southbridge/intel/i82801ix/hdaudio.c @@ -15,8 +15,6 @@ #define HDA_ICII_BUSY (1 << 0) #define HDA_ICII_VALID (1 << 1)
-typedef struct southbridge_intel_i82801ix_config config_t; - static int set_bits(void *port, u32 mask, u32 val) { u32 reg32; diff --git a/src/southbridge/intel/i82801jx/hdaudio.c b/src/southbridge/intel/i82801jx/hdaudio.c index 7968f71..7ad6614 100644 --- a/src/southbridge/intel/i82801jx/hdaudio.c +++ b/src/southbridge/intel/i82801jx/hdaudio.c @@ -15,8 +15,6 @@ #define HDA_ICII_BUSY (1 << 0) #define HDA_ICII_VALID (1 << 1)
-typedef struct southbridge_intel_i82801jx_config config_t; - static int set_bits(void *port, u32 mask, u32 val) { u32 reg32;
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)