Attention is currently required from: Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58117 )
Change subject: mb/google/guybrush: Override SPI Fast speeds ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/58117/comment/cbd342bd_05a96777 PS10, Line 122: config OVERRIDE_EFS_SPI_SPEED_MIN_BOARD : hex : default 0x4 if BOARD_GOOGLE_GUYBRUSH : default 0xffffffff : help : Minimum board version starting which the Override EFS SPI Speed : configuration has to be applied. this breaks the build when selecting EM100, since then OVERRIDE_EFS_SPI_SPEED_MIN_BOARD won't be specified and default to 0 resulting in this build failure:
src/mainboard/google/guybrush/chromeos.c: In function 'mainboard_spi_fast_speed_override': src/mainboard/google/guybrush/chromeos.c:45:16: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] if (board_ver >= CONFIG_OVERRIDE_EFS_SPI_SPEED_MIN_BOARD) ^~