Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64341 )
Change subject: cpu/x86/mp_init.c: Use existing code to create cpu struct device
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Patchset:
PS9:
verified that this works on amd/mandolin
out of scope for this patch, but when looking at the patch i wondered if changing
struct device *new = add_cpu_device(cpu_bus, info->cpu->path.apic.apic_id + i, 1);
to
struct device *new = add_cpu_device(cpu_bus, i, 1);
and changing
struct device *bsp = add_cpu_device(cpu_bus, lapicid(), 1);
to
struct device *bsp = add_cpu_device(cpu_bus, 0, 1);
would result in the same behavior with the code being a bit clearer. verified that this works on mandolin, but haven't 100% traced the code, so i'm not certain if that would be correct in all cases
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80baadd405b31d6be2fdbb894b0f4b7c775da6f8
Gerrit-Change-Number: 64341
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 05 Nov 2022 02:20:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment