flora.fu@mediatek.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58794 )
Change subject: soc/mediatek/mt8195: add apusys init flow ......................................................................
Patch Set 3:
(4 comments)
File src/soc/mediatek/mt8195/apusys.c:
https://review.coreboot.org/c/coreboot/+/58794/comment/ee3a1596_8f14ae48 PS2, Line 13: int i;
`unsigned int` or `size_t`
Ack
https://review.coreboot.org/c/coreboot/+/58794/comment/1e0c03a6_460673cb PS2, Line 16: printk(BIOS_INFO, "APU_MBOX %p = %#x\n",
Why is this level info?
The level can be reduce to DEBUG. The next patch will fix it.
https://review.coreboot.org/c/coreboot/+/58794/comment/9445fbf7_f726d52e PS2, Line 24: int i;
Ditto.
Ack
https://review.coreboot.org/c/coreboot/+/58794/comment/2883e706_e0d2423d PS2, Line 26: Setup
Set up
Ack