Attention is currently required from: Furquan Shaikh, Bernardo Perez Priego.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58215 )
Change subject: util/cse_serger: Add command `create-cse-region`
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/cbfstool/cse_serger.c:
https://review.coreboot.org/c/coreboot/+/58215/comment/e4aacfa0_63cf7969
PS3, Line 720: if (i == 0) {
It is a little weird. […]
Ah, I see... hmm, yeah I'd rather not have lines that don't end in semicolons
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib087f5516e5beb6390831ef4e34b0b067d3fbc8b
Gerrit-Change-Number: 58215
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 21:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment