Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Mario Scheithauer, Angel Pons, Subrata Banik, Lean Sheng Tan, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55565 )
Change subject: soc/intel/common: Move PMC EPOC related code to Intel common code
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/55565/comment/b70fb509_ca4662c1
PS7, Line 722: #if CONFIG(PMC_EPOC)
Looks like the dead_code() wasnt as helpful though,Intel Hacuvar board is complaining error( https:/ […]
Looks like denverton_ns does not have a `uint8_t *pmc_mmio_regs(void)` function defined
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5fd3c4a648964678ee40ed0f60ca10fe7953f56
Gerrit-Change-Number: 55565
Gerrit-PatchSet: 9
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 17 Jun 2021 15:35:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-MessageType: comment