Change in coreboot[master]: mb/google/hatch/variants/helios: Modify touchscreen power on sequence

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35907 )

Change subject: mb/google/hatch/variants/helios: Modify touchscreen power on sequence
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35907/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35907/2/src/mainboard/google/hatch/... 
PS2, Line 113: 				register "generic.stop_gpio" =
             : 					"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C4)"
             : 				register "generic.stop_delay_ms" = "15"
             : 				register "generic.stop_off_delay_ms" = "5"
> This is not clearly captured in the commit message, but my understanding is that GPP_C4 needs to be  […]

Also, don't you need to set GPP_C4 to low in gpio.c?